From 952e1130115d6f947c7ac6c2486a2e1fa10c3f16 Mon Sep 17 00:00:00 2001 From: Artem Ovchinnikov Date: Wed, 11 Jan 2023 17:17:07 +0300 Subject: [PATCH] Await added to prevent premature dispose --- .../Runtime/External/DOTween/DOTweenAsyncExtensions.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs index 72fcc05..abf18d5 100644 --- a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs +++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs @@ -99,13 +99,13 @@ namespace Cysharp.Threading.Tasks return new UniTask(TweenConfiguredSource.Create(tween, tweenCancelBehaviour, cancellationToken, CallbackType.StepComplete, out var token), token); } - public static UniTask AwaitWithCancellation(this Tween tween, CancellationToken cancellationToken) + public static async UniTask AwaitWithCancellation(this Tween tween, CancellationToken cancellationToken) { Error.ThrowArgumentNullException(tween, nameof(tween)); - if (!tween.IsActive()) return UniTask.CompletedTask; + if (!tween.IsActive()) await UniTask.CompletedTask; - using var registration = cancellationToken.Register(() => + using var registration = cancellationToken.Register(() => { if (tween.IsActive()) { @@ -113,7 +113,7 @@ namespace Cysharp.Threading.Tasks } }); - return tween.ToUniTask(TweenCancelBehaviour.KillAndCancelAwait, cancellationToken); + await tween.ToUniTask(TweenCancelBehaviour.KillAndCancelAwait, cancellationToken); } public struct TweenAwaiter : ICriticalNotifyCompletion